Attention is currently required from: fixeria, lynxis lazus, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email )
Change subject: Introduce EPDG_Tests testsuite
......................................................................
Patch Set 6: Code-Review+1
(6 comments)
Patchset:
PS6:
nice! just some cosmetics
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/6e954307_94c3…
PS6, Line 19: swtrongswan
strongswan
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/8a64f3e0_94c1…
PS6, Line 216: watchdong
watchdog
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/a8ccf961_f230…
PS6, Line 231: /* TODO: maybe use, set to true */
kept intentionally?
File epdg/gen_links.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/0d30aa1d_a178…
PS6, Line 30: #FILES+="SS_DataTypes.asn SS_Errors.asn SS_Operations.asn
SS_PDU_Defs.asn SS_Protocol.asn SS_Types.ttcn SS_EncDec.cc"
commented out FILES here looks like left-overs that should be removed?
File library/DIAMETER_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/b86d0189_8bde…
PS6, Line 2295: //tr_AVP_3GPP_IntegrityKey(?) /* Optional */
do you want to keep the // lines in addition to the TODO comment below?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171
Gerrit-Change-Number: 34778
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 20 Oct 2023 09:14:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment