Attention is currently required from: fixeria, lynxis lazus, pespin.

Patch set 6:Code-Review +1

View Change

6 comments:

• Patchset:

  • Patch Set #6:

    nice! just some cosmetics

• File epdg/EPDG_Tests.ttcn:

  • Patch Set #6, Line 19: swtrongswan

    strongswan

  • Patch Set #6, Line 216: watchdong

    watchdog

  • Patch Set #6, Line 231: /* TODO: maybe use, set to true */

    kept intentionally?

• File epdg/gen_links.sh:

  • Patch Set #6, Line 30: #FILES+="SS_DataTypes.asn SS_Errors.asn SS_Operations.asn SS_PDU_Defs.asn SS_Protocol.asn SS_Types.ttcn SS_EncDec.cc"

    commented out FILES here looks like left-overs that should be removed?

• File library/DIAMETER_Templates.ttcn:

  • Patch Set #6, Line 2295: //tr_AVP_3GPP_IntegrityKey(?) /* Optional */

    do you want to keep the // lines in addition to the TODO comment below?

To view, visit change 34778. To unsubscribe, or for help writing mail filters, visit settings.