[S] Change in osmo-bsc[master]: pcuif_proto: use confirmation flag in struct gsm_pcu_if_pch

Attention is currently required from: osmith, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192 ) Change subject: pcuif_proto: use confirmation flag in struct gsm_pcu_if_pch ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Patchset: PS1: Same as I said on the other patch: I'm not liking this approach. Keep the BSC decoding the message type to know what to do with it, and let the "confirm" variable be simply a bool on whether the BSC answers to the PCU when it schedules/transmits it. File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/b9284b7d_4e084523 PS1, Line 552: if (pch->confirmed_imm_ass) @osmith this should not be a problem since there's a PCUIF version bump 10->11. But yes, it would be nice to have such sort of information in the commit message ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3d2842626b7e8325860ea3160c7d900d39e953a0 Gerrit-Change-Number: 34192 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 13:58:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment