Attention is currently required from: osmith, dexter.
Patch set 1:Code-Review -1
2 comments:
Patchset:
Same as I said on the other patch: I'm not liking this approach. Keep the BSC decoding the message type to know what to do with it, and let the "confirm" variable be simply a bool on whether the BSC answers to the PCU when it schedules/transmits it.
File src/osmo-bsc/pcu_sock.c:
Patch Set #1, Line 552: if (pch->confirmed_imm_ass)
* What happens if using a newer osmo-bsc with an older osmo-pcu which does not send the field? (see […]
@osmith this should not be a problem since there's a PCUIF version bump 10->11. But yes, it would be nice to have such sort of information in the commit message ;)
To view, visit change 34192. To unsubscribe, or for help writing mail filters, visit settings.