22 Oct
2024
22 Oct
'24
11:13 a.m.
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38480?usp=email )
Change subject: ggsn: use libosmocore tundev API to create apn tun device ......................................................................
Patch Set 3:
(1 comment)
File lib/tun.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38480/comment/c1c86c94_f07cbc6d?usp... : PS3, Line 201: err_free_tundev: Instead of duplicating these labels in the same function, maybe add separate functions for the now completely different code paths for `tun_new` with `kernel=true` and `tun_new` with `kernel=false`? IMHO that would make it more readable.
Otherwise LGTM!
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38480?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I4d99ba147ac0f3b414d2efef0068b6b8d6cf0014
Gerrit-Change-Number: 38480
Gerrit-PatchSet: 3
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 22 Oct 2024 09:13:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No