Attention is currently required from: pespin.
View Change
1 comment:
File lib/tun.c:
Patch Set #3, Line 201: err_free_tundev:
Instead of duplicating these labels in the same function, maybe add separate functions for the now completely different code paths for `tun_new` with `kernel=true` and `tun_new` with `kernel=false`? IMHO that would make it more readable.
Otherwise LGTM!
To view, visit change 38480. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I4d99ba147ac0f3b414d2efef0068b6b8d6cf0014
Gerrit-Change-Number: 38480
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: osmith <osmith@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Oct 2024 09:13:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No