Change in osmo-pcu[master]: pcu_l1_if: receive E1 connection parameters

Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31174 ) Change subject: pcu_l1_if: receive E1 connection parameters ...................................................................... Patch Set 4: (5 comments) File src/pcu_l1_if.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/d29f0c80_f731a1e3 PS1, Line 34: struct gsm_e1_subslot; Done https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/27b545f5_f1338c1a PS1, Line 182: int pcu_l1if_get_ccu_conn_pars(struct gsm_e1_subslot *e1_link, uint8_t pdch_ts, uint8_t pdch_trx_no); Done File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/ef2c11f7_aaa7f5d4 PS1, Line 81: struct gsm_e1_subslot e1_link; I don't see it as a problem, but sure we can rename it. https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/cec1abd4_b7786e4d PS1, Line 1003: if (e1_ccu_ind->e1_ts_ss == 255) { Done https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/64fcd4eb_16547c37 PS1, Line 1027: e1_ccu_conn_pars = talloc_zero(tall_pcu_ctx, struct e1_ccu_conn_pars); Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1f926b023205a9ecf78d8a8586d6ac21cc73eb0a Gerrit-Change-Number: 31174 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 17:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment