Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31174 )
Change subject: pcu_l1_if: receive E1 connection parameters ......................................................................
Patch Set 4:
(5 comments)
File src/pcu_l1_if.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/d29f0c80_f731a1e3 PS1, Line 34: struct gsm_e1_subslot;
where does this come from? #include <osmocom/abis/e1_input. […]
Done
https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/27b545f5_f1338c1a PS1, Line 182: int pcu_l1if_get_ccu_conn_pars(struct gsm_e1_subslot *e1_link, uint8_t pdch_ts, uint8_t pdch_trx_no);
please keep same param names other functions. None has the pdch_ prefix.
Done
File src/pcu_l1_if.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/ef2c11f7_aaa7f5d4 PS1, Line 81: struct gsm_e1_subslot e1_link;
is inherited by osmo-bsc you mean you are introducing this same problem now in osmo-pcu? I'm not rea […]
I don't see it as a problem, but sure we can rename it.
https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/cec1abd4_b7786e4d PS1, Line 1003: if (e1_ccu_ind->e1_ts_ss == 255) {
So we are further spreading the use of hardcoded values. […]
Done
https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/64fcd4eb_16547c37 PS1, Line 1027: e1_ccu_conn_pars = talloc_zero(tall_pcu_ctx, struct e1_ccu_conn_pars);
Yes, it my be the only place, but still it makes it more difficult for people trying to understand t […]
Done