Attention is currently required from: pespin, fixeria.

View Change

5 comments:

• File src/pcu_l1_if.h:

  • Patch Set #1, Line 34: struct gsm_e1_subslot;

    where does this come from? #include <osmocom/abis/e1_input. […]

    Done

  • Patch Set #1, Line 182: int pcu_l1if_get_ccu_conn_pars(struct gsm_e1_subslot *e1_link, uint8_t pdch_ts, uint8_t pdch_trx_no);

    please keep same param names other functions. None has the pdch_ prefix.

    Done

• File src/pcu_l1_if.cpp:

  • Patch Set #1, Line 81: struct gsm_e1_subslot e1_link;

    is inherited by osmo-bsc you mean you are introducing this same problem now in osmo-pcu? I'm not rea […]

    I don't see it as a problem, but sure we can rename it.

  • Patch Set #1, Line 1003: if (e1_ccu_ind->e1_ts_ss == 255) {

    So we are further spreading the use of hardcoded values. […]

    Done

  • Patch Set #1, Line 1027: e1_ccu_conn_pars = talloc_zero(tall_pcu_ctx, struct e1_ccu_conn_pars);

    Yes, it my be the only place, but still it makes it more difficult for people trying to understand t […]

    Done

To view, visit change 31174. To unsubscribe, or for help writing mail filters, visit settings.