Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/36633?usp=email )
Change subject: mgcp-client: always send 'm=audio' line
......................................................................
Patch Set 3:
(3 comments)
This change is ready for review.
Commit Message:
https://gerrit.osmocom.org/c/osmo-mgw/+/36633/comment/f8b17c47_58ffb1ee
PS2, Line 37: an IUFP codec. osmo-mgw requires this to accept incoming IuUP
with an IUFP codec but with no remote port known yet
(because CRCX is sent at the time RAB-Assignmen […]
Done
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/36633/comment/6e41f737_4ea404f2
PS2, Line 1371: if ((mgcp_msg->presence & MGCP_MSG_PRESENCE_AUDIO_PORT)) {
yep that's the logic exactly. […]
port == 0
is validated in
https://gerrit.osmocom.org/c/osmo-mgw/+/37233
https://gerrit.osmocom.org/c/osmo-mgw/+/36633/comment/b449c82d_6c843379
PS2, Line 1373: if (!audio_port) {
maybe "if (audio_port == 0) in here matches
better the "audio_port = 0" above, but just nitpick here […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/36633?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id95b629453aec999100b5af821c6a0b9562bb597
Gerrit-Change-Number: 36633
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Jun 2024 14:06:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment