Attention is currently required from: pespin.

View Change

3 comments:

• Commit Message:

  • Patch Set #2, Line 37: an IUFP codec. osmo-mgw requires this to accept incoming IuUP

    with an IUFP codec but with no remote port known yet (because CRCX is sent at the time RAB-Assignmen […]

    Done

• File src/libosmo-mgcp-client/mgcp_client.c:

  • Patch Set #2, Line 1371: if ((mgcp_msg->presence & MGCP_MSG_PRESENCE_AUDIO_PORT)) {

    yep that's the logic exactly. […]

    port == 0 is validated in https://gerrit.osmocom.org/c/osmo-mgw/+/37233

  • Patch Set #2, Line 1373: if (!audio_port) {

    maybe "if (audio_port == 0) in here matches better the "audio_port = 0" above, but just nitpick here […]

    Done

To view, visit change 36633. To unsubscribe, or for help writing mail filters, visit settings.