Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 )
Change subject: mgw_fsm: add MGW support to osmo-hnbgw ......................................................................
Patch Set 18:
(3 comments)
File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/ea7db332_76340e25 PS14, Line 377: switch (ranap_pdu->choice.initiatingMessage.procedureCode) {
Checking with map->is_ps is not sufficient?
Done
File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/f23ec48f_73aec1a8 PS16, Line 379: mgw_fsm_handle_iu_release(map);
Is it expected that after handling IuRElease here, it is forwarded in rua_tx_dt below? If so, please […]
yes, this is expected.
File src/osmo-hnbgw/mgw_fsm.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/a80b4922_9ee9a6cb PS16, Line 376: rc = msgb_resize_area(mgw_fsm_priv->ranap_rab_ass_resp_oph->msg,
Why is this needed? I don't see a point for it.
The msgb_resize_area shouldn't fail, but if it fails it is probably causes other problems that may be very difficult to detect. That is the reason for the OSMO_ASSERT