Attention is currently required from: laforge, pespin.

View Change

3 comments:

• File src/osmo-hnbgw/hnbgw_cn.c:

  • Patch Set #14, Line 377: switch (ranap_pdu->choice.initiatingMessage.procedureCode) {

    Checking with map->is_ps is not sufficient?

    Done

• File src/osmo-hnbgw/hnbgw_cn.c:

  • Patch Set #16, Line 379: mgw_fsm_handle_iu_release(map);

    Is it expected that after handling IuRElease here, it is forwarded in rua_tx_dt below? If so, please […]

    yes, this is expected.

• File src/osmo-hnbgw/mgw_fsm.c:

  • Patch Set #16, Line 376: rc = msgb_resize_area(mgw_fsm_priv->ranap_rab_ass_resp_oph->msg,

    Why is this needed? I don't see a point for it.

    The msgb_resize_area shouldn't fail, but if it fails it is probably causes other problems that may be very difficult to detect. That is the reason for the OSMO_ASSERT

To view, visit change 26795. To unsubscribe, or for help writing mail filters, visit settings.