Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email )
Change subject: S1GW tests: Add test cases for S1 handover procedure ......................................................................
Patch Set 1:
(14 comments)
Patchset:
PS1:
You're adding new testcases, so please edit `s1gw/expected-results.xml` accordingly.
Done
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/125200c8_ab91e... : PS1, Line 9: preperation
prepare, not prepere
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/e900f8bb_eed91... : PS1, Line 12: Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7
`Related: SYS#7309`
Done
File s1gw/S1GW_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/48079bf9_0fa86... : PS1, Line 71: template TargetID
const c_TargetID
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/760ad866_24709... : PS1, Line 76: /* PLMNidentity */ '62F210'O,
Ack, let's please use field names here.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/b27cca8e_eea6c... : PS1, Line 1115: item := tr_E_RABToBeSetupItemHOReq(rab_id := erabs[i].erab_id,
cosmetic: alignment issues
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/38a7f95a_45c7d... : PS1, Line 1185: in ERabList erabs
Unused argument, not needed here.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/c07daa34_791d0... : PS1, Line 1197: in ERabList erabs
Unused argument, not needed here.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/6e106b36_c2075... : PS1, Line 1207: ts_TargetID
`tr_TargetID` (receive template, not send).
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/1a3b070a_e5593... : PS1, Line 1629: MME_UE_S1AP_ID mme_ue_id)
cosmetic: alignment issues
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/f06a167e_e10c6... : PS1, Line 1678: inout ERabList erabs
This function does not modify the given list, so it should be `in`.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/82934de1_d1473... : PS1, Line 1693: inout ERabList erabs
This function does not modify the given list, so it should be `in`.
Done
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/db866013_28578... : PS1, Line 872: Handover Request
I would say "Handover Preparation procedures" here.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/744937ea_92b2f... : PS1, Line 873: preperation
"prepare", not "prepere"
Done