Attention is currently required from: arehbein, daniel, fixeria, laforge, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email )
Change subject: osmo_io: SCTP support ......................................................................
Patch Set 9:
(6 comments)
Patchset:
PS3:
We can probably have a read/write cb passing a cmsg, and then a separate API/cb_helper constructing/ […]
Issue will be fixed later.
Patchset:
PS7:
HAVE_LIBSCTP still missing
Done
File include/osmocom/core/osmo_io.h:
https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/39dac0ae_a82f7b2f PS3, Line 17: // FIXME: This must avoid clashing with the existing definitions in libosmo-netif!!!
I explicitly requested somewhere (review comment or redmine issue) to test build all osmocom softwar […]
I tested compilation with libsccp, osmo-bsc and osmo-msc. There was no clash, so I removed the comment.
File src/core/osmo_io_internal.h:
https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/2cce0515_46f26155 PS1, Line 7: #include <netinet/sctp.h>
Agree to do "if HAVE_LIBSCTP" here.
I added #ifdef HAVE_LIBSCTP.
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/44a62e95_9a8dead4 PS7, Line 340: iofd->mode == OSMO_IO_FD_MODE_SCTP_RECVMSG_SEND) {
If I understand correctly in https://gerrit.osmocom.org/c/libosmocore/+/35910 […]
Yes, it is not required, so I removed it.
https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/35ef9dc6_68f87ed7 PS7, Line 369: } else
else {}
Done