[M] Change in libosmocore[master]: osmo_io: SCTP support

Attention is currently required from: arehbein, daniel, fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email ) Change subject: osmo_io: SCTP support ...................................................................... Patch Set 9: (6 comments) Patchset: PS3: Issue will be fixed later. Patchset: PS7: Done File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/39dac0ae_a82f7b2f PS3, Line 17: // FIXME: This must avoid clashing with the existing definitions in libosmo-netif!!! I tested compilation with libsccp, osmo-bsc and osmo-msc. There was no clash, so I removed the comment. File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/2cce0515_46f26155 PS1, Line 7: #include <netinet/sctp.h> I added #ifdef HAVE_LIBSCTP. File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/44a62e95_9a8dead4 PS7, Line 340: iofd->mode == OSMO_IO_FD_MODE_SCTP_RECVMSG_SEND) { Yes, it is not required, so I removed it. https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/35ef9dc6_68f87ed7 PS7, Line 369: } else Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I89eb519b22d21011d61a7855b2364bc3c295df82 Gerrit-Change-Number: 35068 Gerrit-PatchSet: 9 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein &lt;arehbein(a)sysmocom.de&gt; Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Attention: arehbein &lt;arehbein(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 22 Feb 2024 15:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Comment-In-Reply-To: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-MessageType: comment