Attention is currently required from: arehbein, daniel, fixeria, laforge, pespin.

View Change

6 comments:

• Patchset:

  • Patch Set #3:

    We can probably have a read/write cb passing a cmsg, and then a separate API/cb_helper constructing/ […]

    Issue will be fixed later.

• Patchset:

  • Patch Set #7:

    HAVE_LIBSCTP still missing

    Done

• File include/osmocom/core/osmo_io.h:

  • Patch Set #3, Line 17: // FIXME: This must avoid clashing with the existing definitions in libosmo-netif!!!

    I explicitly requested somewhere (review comment or redmine issue) to test build all osmocom softwar […]

    I tested compilation with libsccp, osmo-bsc and osmo-msc. There was no clash, so I removed the comment.

• File src/core/osmo_io_internal.h:

  • Patch Set #1, Line 7: #include <netinet/sctp.h>

    Agree to do "if HAVE_LIBSCTP" here.

    I added #ifdef HAVE_LIBSCTP.

• File src/core/osmo_io_uring.c:

  • Patch Set #7, Line 340: iofd->mode == OSMO_IO_FD_MODE_SCTP_RECVMSG_SEND) {

    If I understand correctly in https://gerrit.osmocom.org/c/libosmocore/+/35910 […]

    Yes, it is not required, so I removed it.

  • Patch Set #7, Line 369: } else

    else {}

    Done

To view, visit change 35068. To unsubscribe, or for help writing mail filters, visit settings.