[M] Change in osmocom-bb[master]: trx_toolkit/*: Try to avoid copying burst data where possible

Attention is currently required from: kirr. pespin has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email ) Change subject: trx_toolkit/*: Try to avoid copying burst data where possible ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/5c08da22_a5c2e889?u… : PS1, Line 230: msg_burst = memoryview(msg)[self.HDR_LEN:] Not sure if it's really noticeable, you may even skip the memoryview/slice here by checking: if len(msg) == self.HDR_LEN: self.burst = None return msg_burst = memoryview(msg)[self.HDR_LEN:] self.parse_burst(msg_burst) https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/988ed215_075ad04d?u… : PS1, Line 336: burst = burst[:EDGE_BURST_LEN] Can you maybe use the memoryview() thing here too? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I147da2f110dedc863361059c931f609c28a69e9c Gerrit-Change-Number: 39537 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 18:19:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes