Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28818 )
Change subject: hnbgw: test PS RAB GTP mapping
......................................................................
Patch Set 2:
(2 comments)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28818/comment/536cb845_9ed7…
PS1, Line 285: pfcp_remote_ip := "127.0.0.2",
this probably needs to be moved to a mp_pfcp_ip_remote
technically the ttcn3 virt UPF should respond back to whichever IP sends PFCP
requests, i think i left it like this because it felt not properly thought through yet.
does it make sense to set a fixed mp_pfcp_ip_remote? makes the PFCP emulation code
simpler. we always have one fixed SUT. so i guess it makes sense.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28818/comment/94029f0d_1fd9…
PS1, Line 1308: f_sleep(2.0);
is this sleep needed?
i guess i wanted to
"simulate" that the RAB remains in use for a bit of time. sometimes nicer to
have a time delay at such places to help reading logs / traces
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28818
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I93c4689ddc016eb4eb25f8cbdd0142936c6f972b
Gerrit-Change-Number: 28818
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Jul 2022 11:43:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment