fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891 )
Change subject: bsc: Fix CC bits expectancies in TC_rll_sapi_n_reject_dlci_cc ......................................................................
Patch Set 1: Code-Review-2
(1 comment)
I am sorry, but here you aren't fixing the problem but simply adopting the test suite expectations to the current behavior of osmo-bsc. As I said, the problem is in osmo-bsc and it needs to be fixed there. Hence CR-2.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891/1/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891/1/bsc/BSC_Tests.ttcn@2... PS1, Line 2595: int2bit(enum2int(rlid.c), 2)); This is wrong. The encoding of the 'Control Channel type' is different between RSL and BSSAP:
=== RSL
'00'B - FACCH_SDCCH '01'B - SACCH
== BSSAP
'00'B - control channel is not further specified '10'B - represents the FACCH or the SDCCH (this is what we expect) '11'B - represents the SACCH
See 3GPP TS 48.006, section 9.3.2. Quick link (page 34):
https://www.etsi.org/deliver/etsi_ts/148000_148099/148006/16.00.00_60/ts_148...