Change in osmo-ttcn3-hacks[master]: bsc: Fix CC bits expectancies in TC_rll_sapi_n_reject_dlci_cc
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891 ) Change subject: bsc: Fix CC bits expectancies in TC_rll_sapi_n_reject_dlci_cc ...................................................................... bsc: Fix CC bits expectancies in TC_rll_sapi_n_reject_dlci_cc Change-Id: Ie9d88acd083fa0db35e2addec07b2f810bcc8213 Related: OS#4728 Related: SYS#5047 Fixes: 999ceb66373a93c0ab5adf14b313187789288c53 --- M bsc/BSC_Tests.ttcn 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/26891/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 0dd4440..e97121b 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -2578,6 +2578,7 @@ var octetstring rnd_data := f_rnd_octstring(16); var RSL_Message rx_rsl; var DchanTuple dt; + var RslLinkId rlid := valueof(ts_RslLinkID_DCCH(3)); f_init(1); @@ -2590,8 +2591,8 @@ rx_rsl := f_exp_ipa_rx(0, tr_RSL_EST_REQ(dt.rsl_chan_nr, tr_RslLinkID_DCCH(3))); /* MS sends unexpected ERROR INDication on DCCH/ACCH SAPI=3 */ - f_ipa_tx(0, ts_RSL_ERROR_IND(dt.rsl_chan_nr, ts_RslLinkID_DCCH(3), ''O)); - f_exp_sapi_n_reject(3, GSM0808_CAUSE_BSS_NOT_EQUIPPED, '10'B); + f_ipa_tx(0, ts_RSL_ERROR_IND(dt.rsl_chan_nr, rlid, ''O)); + f_exp_sapi_n_reject(3, GSM0808_CAUSE_BSS_NOT_EQUIPPED, int2bit(enum2int(rlid.c), 2)); /* Clean up the connection */ BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9d88acd083fa0db35e2addec07b2f810bcc8213 Gerrit-Change-Number: 26891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-MessageType: newchange
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891 ) Change subject: bsc: Fix CC bits expectancies in TC_rll_sapi_n_reject_dlci_cc ...................................................................... Patch Set 1: Code-Review-2 (1 comment) I am sorry, but here you aren't fixing the problem but simply adopting the test suite expectations to the current behavior of osmo-bsc. As I said, the problem is in osmo-bsc and it needs to be fixed there. Hence CR-2. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891/1/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891/1/bsc/BSC_Tests.ttcn@2... PS1, Line 2595: int2bit(enum2int(rlid.c), 2)); This is wrong. The encoding of the 'Control Channel type' is different between RSL and BSSAP: === RSL '00'B - FACCH_SDCCH '01'B - SACCH == BSSAP '00'B - control channel is not further specified '10'B - represents the FACCH or the SDCCH (this is what we expect) '11'B - represents the SACCH See 3GPP TS 48.006, section 9.3.2. Quick link (page 34): https://www.etsi.org/deliver/etsi_ts/148000_148099/148006/16.00.00_60/ts_148... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9d88acd083fa0db35e2addec07b2f810bcc8213 Gerrit-Change-Number: 26891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jan 2022 13:05:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891 ) Change subject: bsc: Fix CC bits expectancies in TC_rll_sapi_n_reject_dlci_cc ...................................................................... Abandoned osmo-bsc fix available in https://gerrit.osmocom.org/c/osmo-bsc/+/26893 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9d88acd083fa0db35e2addec07b2f810bcc8213 Gerrit-Change-Number: 26891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: abandon
participants (2)
-
fixeria -
pespin