Attention is currently required from: fixeria, laforge, neels, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email )
Change subject: pick up all *.vty in EXTRA_DIST
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Aren't the packages in OBS built from 'make
dist'??????
The packages in OBS are built from the debian source packages created from the checked out
git tree with "dpkg-buildpackage -S".
In my opinion it is fine to use wildcards here. We don't have the use case described
in
https://www.gnu.org/software/automake/manual/1.8.4/html_node/wildcards.html as we
don't run "make dist" in a developer's checked out tree and then publish
that tarball. Instead we have a jenkins job that always runs "make dist" in a
clean git checkout, in a known environment, and only from there we publish the tarballs.
This also means we don't need to care much about portability here IMHO.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id28e020fc59b83d1b4cd0e5b72314a46bea62259
Gerrit-Change-Number: 35872
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Feb 2024 08:25:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment