Attention is currently required from: fixeria, laforge, neels, pespin.

Patch set 1:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Aren't the packages in OBS built from 'make dist'??????

    The packages in OBS are built from the debian source packages created from the checked out git tree with "dpkg-buildpackage -S".

    In my opinion it is fine to use wildcards here. We don't have the use case described in https://www.gnu.org/software/automake/manual/1.8.4/html_node/wildcards.html as we don't run "make dist" in a developer's checked out tree and then publish that tarball. Instead we have a jenkins job that always runs "make dist" in a clean git checkout, in a known environment, and only from there we publish the tarballs. This also means we don't need to care much about portability here IMHO.

To view, visit change 35872. To unsubscribe, or for help writing mail filters, visit settings.