Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29996 )
Change subject: Improve MS logging ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/ab606b73_5f14b315 PS2, Line 1030: if (tlli != GSM_RESERVED_TMSI) For the sake of explicitness, I would print TLLI unconditionally.
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/1f01e277_fc964f3b PS2, Line 1032: MSCLS Everything is about the MS here, so 'MS' in 'MSCLS' is redundant IMO.
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/f432523b_106557b3 PS2, Line 1032: PRIu8 "-%" PRIu8 I suggest prefixing the values with 'G' and 'E', respectively. This way it's clear which is GPRS class and which is EGPRS class: CLS-G%02u-E%02u.