Attention is currently required from: osmith, pespin.

Patch set 2:Code-Review +1

View Change

3 comments:

• File src/gprs_ms.c:

  • Patch Set #2, Line 1030: if (tlli != GSM_RESERVED_TMSI)

    For the sake of explicitness, I would print TLLI unconditionally.

  • Patch Set #2, Line 1032: MSCLS

    Everything is about the MS here, so 'MS' in 'MSCLS' is redundant IMO.

  • Patch Set #2, Line 1032: PRIu8 "-%" PRIu8

    I suggest prefixing the values with 'G' and 'E', respectively. This way it's clear which is GPRS class and which is EGPRS class: CLS-G%02u-E%02u.

To view, visit change 29996. To unsubscribe, or for help writing mail filters, visit settings.