[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY

Attention is currently required from: fixeria, laforge, pespin. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email ) Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... Patch Set 3: (1 comment) File doc/manuals/chapters/server.adoc: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/6625a68c_8a8e78c5?us… : PS3, Line 117: This is actually quite a lengthy discussion. Yes, in theory it can happen that we try to reopen an existing file. Right now we use creat() in restart_pcap(), which will truncate the file to zero length if it already exists. In general it's more difficult than it seems to actually ending up opening the same file, because the file name is based on the timestamp of the time at which we received the packet up to second granularity, so we have further entropy there to end up with a different file name. But yes, it could happen, see test_check_localtime_dst_europe() I just added. We could add an extra check to avoid store the "last_write" tm if the current tm is older in time than the one in use. But it makes sense to do this in a follow-up patch imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Dec 2024 11:30:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>