Attention is currently required from: fixeria, laforge, pespin.
1 comment:
File doc/manuals/chapters/server.adoc:
Maybe worth document what happens if the system's localtime goes backward (daylight savings time or […]
This is actually quite a lengthy discussion.
Yes, in theory it can happen that we try to reopen an existing file. Right now we use creat() in restart_pcap(), which will truncate the file to zero length if it already exists.
In general it's more difficult than it seems to actually ending up opening the same file, because the file name is based on the timestamp of the time at which we received the packet up to second granularity, so we have further entropy there to end up with a different file name. But yes, it could happen, see test_check_localtime_dst_europe() I just added.
We could add an extra check to avoid store the "last_write" tm if the current tm is older in time than the one in use. But it makes sense to do this in a follow-up patch imho.
To view, visit change 39158. To unsubscribe, or for help writing mail filters, visit settings.