Attention is currently required from: neels.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/30461 )
Change subject: tunmap: choose local GTP addr by Network Instance IEs
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/osmo-upf/up_session.c:
https://gerrit.osmocom.org/c/osmo-upf/+/30461/comment/4685ee8f_dd679e62
PS2, Line 124: struct osmo_sockaddr osa = {};
This (`{}`) doesn't seem to be ISO C (or I misunderstood the syntax section of the
latest draft), is it some GCC extension or anything like that (?). Initialization to zero
of all members I guess?
File tests/netinst.vty:
https://gerrit.osmocom.org/c/osmo-upf/+/30461/comment/a9288fc7_0ca5422d
PS2, Line 32: <cr>
Trailing space (if that's how it looks in Gerrit). Not sure if we care if it isn't
source code...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/30461
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I15ee046a1c37b83b8a83527a67a6215a30106d81
Gerrit-Change-Number: 30461
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Dec 2022 16:41:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment