Attention is currently required from: neels. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30461 )
Change subject: tunmap: choose local GTP addr by Network Instance IEs ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/osmo-upf/up_session.c:
https://gerrit.osmocom.org/c/osmo-upf/+/30461/comment/4685ee8f_dd679e62 PS2, Line 124: struct osmo_sockaddr osa = {}; This (`{}`) doesn't seem to be ISO C (or I misunderstood the syntax section of the latest draft), is it some GCC extension or anything like that (?). Initialization to zero of all members I guess?
File tests/netinst.vty:
https://gerrit.osmocom.org/c/osmo-upf/+/30461/comment/a9288fc7_0ca5422d PS2, Line 32: <cr> Trailing space (if that's how it looks in Gerrit). Not sure if we care if it isn't source code...