Attention is currently required from: neels.

Patch set 2:Code-Review +1

View Change

2 comments:

• File src/osmo-upf/up_session.c:

  • Patch Set #2, Line 124: struct osmo_sockaddr osa = {};

    This (`{}`) doesn't seem to be ISO C (or I misunderstood the syntax section of the latest draft), is it some GCC extension or anything like that (?). Initialization to zero of all members I guess?

• File tests/netinst.vty:

  • Patch Set #2, Line 32: <cr>

    Trailing space (if that's how it looks in Gerrit). Not sure if we care if it isn't source code...

To view, visit change 30461. To unsubscribe, or for help writing mail filters, visit settings.