Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email )
Change subject: ss7 vty: Fix insert order of routes with higher priority ......................................................................
Patch Set 3:
(8 comments)
File src/osmo_ss7.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/5ec169d3_160a59... : PS2, Line 664: noy
typo: not
Done
File src/osmo_ss7.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/54bb3788_d68526... : PS3, Line 664: insertd inserted
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/2d6c6b1d_6d4dee... : PS3, Line 681: struct osmo_ss7_route * put this into the same line as the function name? same for: * osmo_ss7_route_set_linkset * osmo_ss7_route_insert
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/b2320e8d_3294e3... : PS3, Line 736: return -ENODEV; other error returns above log a message. log one here too for consistency?
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/7a8872fa_35f207... : PS3, Line 857: LOGSS7(rtbl->inst, LOGL_ERROR, "Refusing to create duplicate route: " maybe be more specific here: "Refusing to create route with existing linkset name"
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/f1c470df_dffba8... : PS3, Line 902: } (I thought a rc < 0 case is missing here, but looks like you handled all cases before so this is not possible.)
File src/osmo_ss7_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/6010e0d7_ee01bc... : PS3, Line 401: find set?
File tests/vty/osmo_stp_route_prio.vty:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/a0d90c34_00c383... : PS2, Line 71: Os
This comment should be removed now?
Done