Attention is currently required from: laforge, neels, pespin.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email )
Change subject: per-HNB GTP-U traffic counters via nft ......................................................................
Patch Set 4:
(6 comments)
File src/osmo-hnbgw/hnbgw.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/27cb50fa_a1c2d0c6 PS4, Line 585: if (getpeername(fd, &osa.u.sa, &socklen)){ space required before the open brace '{'
File src/osmo-hnbgw/nft_kpi.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/cfffabca_cb61ff3e PS4, Line 193: static const char *nft_thread_req_type_name[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/f95be9ba_bdf88f8b PS4, Line 620: while (1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/d0cc942e_62412f17 PS4, Line 652: if (period_us < 1) suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/cfff3b06_24b62f7b PS4, Line 653: period_us = 1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/4075a7e7_9e0e6e81 PS4, Line 653: period_us = 1; please, no spaces at the start of a line