Attention is currently required from: laforge, neels, pespin.

View Change

6 comments:

• File src/osmo-hnbgw/hnbgw.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220):

    Patch Set #4, Line 585: if (getpeername(fd, &osa.u.sa, &socklen)){

    space required before the open brace '{'

• File src/osmo-hnbgw/nft_kpi.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220):

    Patch Set #4, Line 193: static const char *nft_thread_req_type_name[] = {

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220):

    Patch Set #4, Line 620: while (1) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220):

    Patch Set #4, Line 652: if (period_us < 1)

    suspect code indent for conditional statements (7, 15)

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220):

    Patch Set #4, Line 653: period_us = 1;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220):

    Patch Set #4, Line 653: period_us = 1;

    please, no spaces at the start of a line

To view, visit change 36539. To unsubscribe, or for help writing mail filters, visit settings.