Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35452?usp=email )
Change subject: Implement convoluted encoding of UCS-2 as per TS 102 221 Annex A ......................................................................
Patch Set 6:
(2 comments)
File pySim/construct.py:
https://gerrit.osmocom.org/c/pysim/+/35452/comment/88c1b685_619fccae PS5, Line 79: ch.to_bytes(1, byteorder='big'),
Not critical, but for just one byte I would rather do `bytes([ch])`. Same below.
Done
https://gerrit.osmocom.org/c/pysim/+/35452/comment/31d5f9f4_6722184e PS5, Line 81: elif obj[0] == 0x82:
We may want to raise an exception if `obj[0]` is neither `0x81` nor `0x82`, rather than returning `N […]
Done