Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/35452?usp=email )
Change subject: Implement convoluted encoding of UCS-2 as per TS 102 221 Annex A
......................................................................
Patch Set 6:
(2 comments)
File pySim/construct.py:
https://gerrit.osmocom.org/c/pysim/+/35452/comment/88c1b685_619fccae
PS5, Line 79: ch.to_bytes(1, byteorder='big'),
Not critical, but for just one byte I would rather do
`bytes([ch])`. Same below.
Done
https://gerrit.osmocom.org/c/pysim/+/35452/comment/31d5f9f4_6722184e
PS5, Line 81: elif obj[0] == 0x82:
We may want to raise an exception if `obj[0]` is
neither `0x81` nor `0x82`, rather than returning `N […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/35452?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic8bc8f71079faec1bf0e538dc0dfa21403869c6d
Gerrit-Change-Number: 35452
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Dec 2023 17:52:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment