[S] Change in osmo-ttcn3-hacks[master]: library/GTPv1U_Templates: Mark parameters as templates

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645?usp=email ) Change subject: library/GTPv1U_Templates: Mark parameters as templates ...................................................................... Patch Set 2: (2 comments) File library/GTPv1U_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645/comment/ae42e5b9_05e6… PS1, Line 58: template (value) As I said, yes, it helps for complex types like records and unions. But I still don't see why would you want to pass e.g. `teid` in form of a template. Do we even have templates for `teid` or `seq`? I don't think so. By commenting here I don't want to block your patchset. I just wanted to bring up a general trend that I am seeing in our code base: are we doing this for a specific reason or just because it looks prettier if all parameters of a template are templates too ;) For now I don't see a clear motivation for doing that. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645/comment/51e25797_617a… PS1, Line 61: template (value) GTPU_IEs ies If this was the actual IUT and not tests, I would argue that this freedom comes at the cost of performance. However, this is tests and we don't care much... we can even create functions returning const values, just because we can. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I278f7dbc64704c1ba2b8a75d6f540ac52b067598 Gerrit-Change-Number: 37645 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jul 2024 09:00:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment