Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File library/GTPv1U_Templates.ttcn:

  • Patch Set #1, Line 58: template (value)

    It helps in easying the posibility to pass both values and template.

    As I said, yes, it helps for complex types like records and unions. But I still don't see why would you want to pass e.g. `teid` in form of a template. Do we even have templates for `teid` or `seq`? I don't think so.

    By commenting here I don't want to block your patchset. I just wanted to bring up a general trend that I am seeing in our code base: are we doing this for a specific reason or just because it looks prettier if all parameters of a template are templates too ;)

    For now I don't see a clear motivation for doing that.

  • Patch Set #1, Line 61: template (value) GTPU_IEs ies

    It doesn't cause a problem either, and allows for more freedom to the caller/user of the template.

    If this was the actual IUT and not tests, I would argue that this freedom comes at the cost of performance. However, this is tests and we don't care much... we can even create functions returning const values, just because we can.

To view, visit change 37645. To unsubscribe, or for help writing mail filters, visit settings.