Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30216 )
Change subject: tbf_fsm: Move osmo_fsm_inst fi out of struct tbf_fsm_ctx ......................................................................
Patch Set 2:
(1 comment)
File src/tbf.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/30216/comment/fcf20b82_5d57f633 PS1, Line 260: state_fi
But this is one is the main tbf_fsm, right? Both ul_ass_fsm and dl_ass_fsm are supplementary ones, A […]
It's not the "main" tbf, it's the "state" tbf as its name indicates.
I can rename "state_fsm" as "state_fsm_ctx" if you want, in a separate follow-up commit.
Why allocating the context dynamically if it can be allocated as part of the tbf struct? there's no need for that.