Attention is currently required from: fixeria.
View Change
1 comment:
File src/tbf.h:
Patch Set #1, Line 260: state_fi
But this is one is the main tbf_fsm, right? Both ul_ass_fsm and dl_ass_fsm are supplementary ones, A […]
It's not the "main" tbf, it's the "state" tbf as its name indicates.
I can rename "state_fsm" as "state_fsm_ctx" if you want, in a separate follow-up commit.
Why allocating the context dynamically if it can be allocated as part of the tbf struct? there's no need for that.
To view, visit change 30216. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I03e691ccf6a94431caa55653349158f5b85db017
Gerrit-Change-Number: 30216
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Nov 2022 15:36:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment