Attention is currently required from: fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )
Change subject: WIP: vty: Add check against sensible default value for Ny1 ......................................................................
Patch Set 9:
(4 comments)
File include/osmocom/bsc/bts.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/3e92aee9_e2d4e3a7 PS5, Line 837: static inline bool gsm_bts_check_ny1
Is it really necessary to have this function static inline in a header? […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/51b4dada_6ddab62a PS5, Line 839: struct gsm_lchan *gl
const […]
it's the initials of `gsm_lchan`. Do you mean I should put `struct gsm_lchang const *` instead to make clear contents are not to be changed?
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/03af4f18_96a50806 PS5, Line 842: if (gl) {
Not critical, but could be done a bit simpler: […]
I would actually prefer it as is, at least I find there is a gain in readability that makes up for a few additional lines.
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/aacec502_8d726321 PS5, Line 855: talloc_strdup_append
Looks way too complicated, IMO. How about this? […]
Ah yeah thanks! I don't know what I was doing there