Change in osmo-bsc[master]: WIP: vty: Add check against sensible default value for Ny1

Attention is currently required from: fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 ) Change subject: WIP: vty: Add check against sensible default value for Ny1 ...................................................................... Patch Set 9: (4 comments) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/3e92aee9_e2d4e3a7 PS5, Line 837: static inline bool gsm_bts_check_ny1 Done https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/51b4dada_6ddab62a PS5, Line 839: struct gsm_lchan *gl it's the initials of `gsm_lchan`. Do you mean I should put `struct gsm_lchang const *` instead to make clear contents are not to be changed? https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/03af4f18_96a50806 PS5, Line 842: if (gl) { I would actually prefer it as is, at least I find there is a gain in readability that makes up for a few additional lines. https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/aacec502_8d726321 PS5, Line 855: talloc_strdup_append Ah yeah thanks! I don't know what I was doing there -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 Gerrit-Change-Number: 30602 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Dec 2022 15:52:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment