Attention is currently required from: fixeria.

View Change

4 comments:

• File include/osmocom/bsc/bts.h:

  • Patch Set #5, Line 837: static inline bool gsm_bts_check_ny1

    Is it really necessary to have this function static inline in a header? […]

    Done

  • Patch Set #5, Line 839: struct gsm_lchan *gl

    const […]

    it's the initials of `gsm_lchan`. Do you mean I should put `struct gsm_lchang const *` instead to make clear contents are not to be changed?

  • Patch Set #5, Line 842: if (gl) {

    Not critical, but could be done a bit simpler: […]

    I would actually prefer it as is, at least I find there is a gain in readability that makes up for a few additional lines.

  • Patch Set #5, Line 855: talloc_strdup_append

    Looks way too complicated, IMO. How about this? […]

    Ah yeah thanks! I don't know what I was doing there

To view, visit change 30602. To unsubscribe, or for help writing mail filters, visit settings.