Attention is currently required from: arehbein, fixeria, laforge, neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email )
Change subject: Introduce per-BTS timers, RLC timer commands ......................................................................
Patch Set 17:
(3 comments)
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/4c9b74ec_01aa9c47 PS16, Line 235:
You could submit this a a preparation patch.
This has been ignored.
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/22fb9289_e4403213 PS16, Line 346: if (bts->gprs.mode == BTS_GPRS_NONE) {
I looked at what current code does and no or most gprs command didn't work unless we're in gprs mode […]
I think for setting timers is totally fine being able to configure them, otherwise config files are going to be failing if someone disables gprs temporarily. Please remove this check, I see no good use for it.
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/5a8d06ab_2271abb0 PS16, Line 351: ++group;
we tend to use group++ unless there's a good reason to use preinc.
this comment was ignored.