Attention is currently required from: arehbein, fixeria, laforge, neels.
3 comments:
File src/osmo-bsc/bsc_vty.c:
You could submit this a a preparation patch.
This has been ignored.
Patch Set #16, Line 346: if (bts->gprs.mode == BTS_GPRS_NONE) {
I looked at what current code does and no or most gprs command didn't work unless we're in gprs mode […]
I think for setting timers is totally fine being able to configure them, otherwise config files are going to be failing if someone disables gprs temporarily.
Please remove this check, I see no good use for it.
Patch Set #16, Line 351: ++group;
we tend to use group++ unless there's a good reason to use preinc.
this comment was ignored.
To view, visit change 31878. To unsubscribe, or for help writing mail filters, visit settings.