Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29861 )
Change subject: Rename and move func checking if amr mode is explicitly configured ......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/mgcp/mgcp_codec.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/29861/comment/a38cb982_7f3e66c3 PS1, Line 20: bool mgcp_codec_amr_mode_is_indicated(const struct mgcp_rtp_codec *codec);
First dot: I'll rename it to mgcp_codec_amr_mode_is_indicated(). […]
Ah I remember why I moved it. To have it in mgcp_codec.c, similar to mgcp_codec_amr_is_octet_aligned(). This also allows quickly seeing the difference between those. I know the logic may not be complaint, but that's how it is now, I'm simply cleaning up the code and clarifying it here. Change of logic (and breaking backward compatibility) is another topic (you created a ticket for it).