Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/29861
)
Change subject: Rename and move func checking if amr mode is explicitly configured
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/mgcp/mgcp_codec.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/29861/comment/a38cb982_7f3e66c3
PS1, Line 20: bool mgcp_codec_amr_mode_is_indicated(const struct mgcp_rtp_codec *codec);
First dot: I'll rename it to
mgcp_codec_amr_mode_is_indicated(). […]
Ah I remember why I moved it. To have it in
mgcp_codec.c, similar to mgcp_codec_amr_is_octet_aligned(). This also allows quickly
seeing the difference between those.
I know the logic may not be complaint, but that's how it is now, I'm simply
cleaning up the code and clarifying it here. Change of logic (and breaking backward
compatibility) is another topic (you created a ticket for it).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/29861
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I8dce3038ebccf5e1e37e2908070a67d66693a96f
Gerrit-Change-Number: 29861
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Oct 2022 11:26:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment