Attention is currently required from: neels.

View Change

1 comment:

• File include/osmocom/mgcp/mgcp_codec.h:

  • Patch Set #1, Line 20: bool mgcp_codec_amr_mode_is_indicated(const struct mgcp_rtp_codec *codec);

    First dot: I'll rename it to mgcp_codec_amr_mode_is_indicated(). […]

    Ah I remember why I moved it. To have it in mgcp_codec.c, similar to mgcp_codec_amr_is_octet_aligned(). This also allows quickly seeing the difference between those.
    I know the logic may not be complaint, but that's how it is now, I'm simply cleaning up the code and clarifying it here. Change of logic (and breaking backward compatibility) is another topic (you created a ticket for it).

To view, visit change 29861. To unsubscribe, or for help writing mail filters, visit settings.