Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33312 )
Change subject: mgw: Allow auditing speciall 'null' endpoint ......................................................................
Patch Set 2: Verified-1
(3 comments)
Patchset:
PS2: This seems to work nicely with AUEP, but when I try with CRCX, it crashes, looks like some check is missing.
File src/libosmo-mgcp/mgcp_protocol.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/33312/comment/c6ed1bec_43843897 PS2, Line 399: rq.endp = mgcp_endp_by_name(&rc, pdata.epname, pdata.cfg); I find this logic a bit difficult to read but I think I got it.
https://gerrit.osmocom.org/c/osmo-mgw/+/33312/comment/a5496eaf_e6e3a298 PS2, Line 473: Are you sure that we do not have to check in the other handler. What if someone tries to send a CRCX to a null endpoint?
I tried your patch and when I send the following, osmo-mgw crashes:
CRCX 1 null@mgw MGCP 1.0 C: 12345 L: p:20, a:AMR, nt:IN M: loopback