Attention is currently required from: pespin.
Patch set 2:Verified -1
3 comments:
Patchset:
This seems to work nicely with AUEP, but when I try with CRCX, it crashes, looks like some check is missing.
File src/libosmo-mgcp/mgcp_protocol.c:
Patch Set #2, Line 399: rq.endp = mgcp_endp_by_name(&rc, pdata.epname, pdata.cfg);
I find this logic a bit difficult to read but I think I got it.
Are you sure that we do not have to check in the other handler. What if someone tries to send a CRCX to a null endpoint?
I tried your patch and when I send the following, osmo-mgw crashes:
CRCX 1 null@mgw MGCP 1.0
C: 12345
L: p:20, a:AMR, nt:IN
M: loopback
To view, visit change 33312. To unsubscribe, or for help writing mail filters, visit settings.