Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email )
Change subject: SGSN: add testcases for PDP Context Status ......................................................................
Patch Set 10: Code-Review-1
(7 comments)
File library/L3_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/6866b88d_2a3c9... : PS10, Line 363: omit `value` here
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/1dabb73c_00cde... : PS10, Line 2446: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT); Do you eventually expect ACCEPT or REJECT? I see you permit both...
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/2b5e978a_7bbf4... : PS10, Line 2475: f_TC_attach_pdp_act_rau_pdp_ctx_status_ue_more Am I correct that this function is 99% identical to `f_TC_attach_pdp_act_rau_pdp_ctx_status_same()` and the only difference is `pdp_status` values? If so, I would appreciate reducing code duplication.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/9a824762_04e31... : PS10, Line 2503: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT); Likewise, receiving a REJECT here will unblock the alt statement and the testcase will finish. It's unclear if the SGSN shall ACCEPT or REJECT the RAU request...
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/b6c0d50b_b8475... : PS10, Line 2548: as_gmm_auth Is the authentication expected to happen before or after the procedures implemented in `as_ggsn_gtp_ctx_del_req`?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/e94c001e_2d880... : PS10, Line 2554: Timeout rx RAU Reject This does not reflect the actual expectations...
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/84c7be4c_10750... : PS10, Line 2574: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT); Same here: REJECT vs ACCEPT.