Attention is currently required from: lynxis lazus.
Patch set 10:Code-Review -1
7 comments:
File library/L3_Templates.ttcn:
`value` here
File sgsn/SGSN_Tests.ttcn:
Patch Set #10, Line 2446: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT);
Do you eventually expect ACCEPT or REJECT? I see you permit both...
Patch Set #10, Line 2475: f_TC_attach_pdp_act_rau_pdp_ctx_status_ue_more
Am I correct that this function is 99% identical to `f_TC_attach_pdp_act_rau_pdp_ctx_status_same()` and the only difference is `pdp_status` values? If so, I would appreciate reducing code duplication.
Patch Set #10, Line 2503: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT);
Likewise, receiving a REJECT here will unblock the alt statement and the testcase will finish. It's unclear if the SGSN shall ACCEPT or REJECT the RAU request...
Patch Set #10, Line 2548: as_gmm_auth
Is the authentication expected to happen before or after the procedures implemented in `as_ggsn_gtp_ctx_del_req`?
Patch Set #10, Line 2554: Timeout rx RAU Reject
This does not reflect the actual expectations...
Patch Set #10, Line 2574: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT);
Same here: REJECT vs ACCEPT.
To view, visit change 39262. To unsubscribe, or for help writing mail filters, visit settings.