25 Nov
2024
25 Nov
'24
3:24 p.m.
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email )
Change subject: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI
......................................................................
Patch Set 6:
(4 comments)
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/26345d42_0ff1…
:
PS6, Line 240: as_mm_identity
Maybe deriving two smaller altsteps
(`as_mm_identity_imsi` and `as_mm_identity_imei`) from this one […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/97473fc5_104b…
:
PS6, Line 265: as_receive_l3
This again looks 99% identical to the existing
`f_receive_l3()`, so again code duplication. […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/70e12eb0_13c8…
:
PS6, Line 578: allow_id_imei_req
We may still receive an identity request here
(regardless of the expectations), and this would block […]
Yes, but that is fine.
The timer is here to fire on unexpected PDUs.
I only care of IMEIs in this change.
Getting a second IMSI doesn't make really sense, because you already authenticated the
user.
Also improving the current test case even more is IMHO out of scope of this change.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/fb558f99_336c…
:
PS6, Line 579: f_process_attach_accept
(cosmetic, but) please move the function call to its
own line.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id49c9e6ef7517a6a831315ac1f9915c50b88beb6
Gerrit-Change-Number: 38398
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Nov 2024 14:24:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>