Change in osmo-ttcn3-hacks[master]: cbc: Test ETWS msg over CBSP

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 ) Change subject: cbc: Test ETWS msg over CBSP ...................................................................... Patch Set 3: (2 comments) File cbc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/4c012693_93bf… PS3, Line 101: var template (omit) uint8_t channel_ind := omit; AFAIU, if msg.channel_ind is omitted, then channel_ind would also be equal to omit. Could you explain why are you adding a separate template variable? What's wrong with passing msg.channel_ind directly? File cbc/CBC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/47e68c4d_87a6… PS3, Line 353: g_pars.exp_cbs_msg.channel_ind Here I guess you're doing ispresent() because g_pars.exp_cbs_msg may be omitted? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie22a00120218a205db11a5622274dcc67435f5de Gerrit-Change-Number: 28912 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment