Attention is currently required from: osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 )
Change subject: add ttcn3-hnbgw-test variant with-pfcp ......................................................................
Patch Set 3:
(1 comment)
File ttcn3-hnbgw-test/jenkins.sh:
https://gerrit.osmocom.org/c/docker-playground/+/29339/comment/50cc92fc_d37c... PS3, Line 82: echo Starting container with STP
It would be really great if you moved duplicated chunks of code into functions, like start_stp, star […]
is it worth the effort? this is just a ci shell script, the single user is our jenkins, it works in this state and changing it would mean another round of testing. The result is more indirection/complexity in calling some shell commands. unlikely that this is a substantial help in future maintenance.