Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 )
Change subject: osmo-bts-sysmo: mute PHY until OML is ready ......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bts-sysmo/l1_if.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/6323e9f3_b4ab199b PS3, Line 1264: if (!trx->mo.opstart_success) IMHO you should move this trx_rf_lock up to line 1258, and you could even simply remove bts_update_status since you are locking now immediatelly. Moreover, this "if (!trx->mo.opstart_success)" doesn't make sense to me, since for sure OPSTART is to be done far afterwards, you can simply drop the check.